chore: more specific name for uploaded artifact#111
Merged
Conversation
This reusable workflow can be used in conjunction with other tools that also produce Sarif results. Making this name more specific reduces the risk of name conflicts. Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
another-rex
approved these changes
Dec 9, 2025
Collaborator
another-rex
left a comment
another-rex
left a comment
There was a problem hiding this comment.
That makes sense, thanks for the change! Since the path is the same I believe this won't be a breaking change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First thanks for the nice work here.
For context, I recently implemented these reusable workflows in a repository and hit an issue of naming conflicts when uploading an artifact. More details here.
On the caller side this is easily fixed by defining a different name, but making these names more specific reduces the chances of more people hitting the same issue when adopting these reusable workflows.